[Webkit-unassigned] [Bug 32510] [GTK] provide an API to control the IconDatabase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32510


Christian Dywan <christian at twotoasts.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83166|                            |review?
               Flag|                            |




--- Comment #6 from Christian Dywan <christian at twotoasts.de>  2011-02-21 07:52:01 PST ---
Created an attachment (id=83166)
 --> (https://bugs.webkit.org/attachment.cgi?id=83166&action=review)
Implement WebKitIconDatabase API

So I implemented WebKitIconDatabase now. With methods

set_path() to set the folder on disk, or NULL to unset it.
get_icon_uri() to get the icon URI for a page URI
get_icon_pixbuf to get a GdkPixbuf for a page URI
clear() to clear all icons
"icon-loaded" signal with the page URI as the argument, similar to the same signal on WebKitWebView but emitted for any icon including sub frames. This makes it possible to handle icon updates isolated from a particular view (tab).

I also added get_icon_pixbuf() to WebKitWebView because I figure this is a very common use case and I know that a lot of people ask for this in #webkit-gtk, and it is so much easier and also more efficient than having to load the icon with WebKitDownload.

No retaining API as of yet, I'm a bit unsure if/ how this should be exposed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.