[Webkit-unassigned] [Bug 54786] Devirtualize JSCell::classInfo()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54786


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83045|review?                     |review+
               Flag|                            |




--- Comment #4 from Sam Weinig <sam at webkit.org>  2011-02-18 19:17:01 PST ---
(From update of attachment 83045)
View in context: https://bugs.webkit.org/attachment.cgi?id=83045&action=review

> Source/JavaScriptCore/ChangeLog:266
> +        (JSC::Structure::toDictionaryTransition):
> +        * runtime/Structure.h:
> +        (JSC::Structure::create):
> +        (JSC::Structure::classInfo):
> +

I am not sure how much of this wall of text is really necessary.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:587
> -    Jump notObject = branch8(NotEqual, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo) + OBJECT_OFFSETOF(TypeInfo, m_type)), Imm32(ObjectType));
> +    Jump notObject = branch8(NotEqual, Address(regT2, OBJECT_OFFSETOF(Structure, m_typeInfo.m_type)), Imm32(ObjectType));

This seems unrelated.

> Source/JavaScriptCore/runtime/InternalFunction.cpp:32
> +void InternalFunction::vtableFix()

I like the name vtableAnchor a bit better.

> Source/JavaScriptCore/runtime/JSByteArray.cpp:56
> +    PassRefPtr<Structure> result = Structure::create(prototype, TypeInfo(ObjectType, StructureFlags), AnonymousSlotCount, classInfo);
>      return result;

This should just return directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.