[Webkit-unassigned] [Bug 54555] [V8] SerializedScriptValue should handle JS exceptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54555





--- Comment #7 from Mihai Parparita <mihaip at chromium.org>  2011-02-18 11:40:28 PST ---
(From update of attachment 82638)
I'm not 100% comfortable with reviewing this change, since I'm not that familiar with the V8 side of things.

View in context: https://bugs.webkit.org/attachment.cgi?id=82638&action=review

> LayoutTests/ChangeLog:3
> +        Reviewed by Mihai Parparita.

Please don't pre-populate this, webkit-patch land and/or the commit queue will pick up the reviewer based on who set the r+ flag.

> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:497
> +                if (m_propertyNames.IsEmpty())

Does this mean that postMessage({}) will report an error now? What was the the rationale for that change (the structured clone argument seems to allow empty objects).

> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:1236
> +    if (status == Serializer::JSFailure) {

You only seem to use JSFailure for empty inputs, so it seems like throwing an exception should be safe here (assuming empty means empty objects, and that is indeed a situation to avoid).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.