[Webkit-unassigned] [Bug 54555] [V8] SerializedScriptValue should handle JS exceptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54555





--- Comment #6 from anton muhin <antonm at chromium.org>  2011-02-16 09:06:26 PST ---
(In reply to comment #5)
> Anton, thanks for the comments!
> 
> (In reply to comment #4)
> > (From update of attachment 82638 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=82638&action=review
> > 
> > LGTM
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Reviewed by Mihai Parparita.
> > 
> > is it indeed reviewed?
> 
> I hope Mihai can have a look :)
> 
> > > Source/WebCore/bindings/v8/SerializedScriptValue.cpp:1240
> > >          didThrow = true;
> > 
> > shouldn't you throw some exception then?
> 
> We don't know whether it's safe to re-enter V8 here.

I think it should be, but I am not insisting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.