[Webkit-unassigned] [Bug 54580] [chromium] Enable media elements statistics support in chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54580





--- Comment #8 from Steve Lacey <sjl at chromium.org>  2011-02-18 10:45:54 PST ---
(In reply to comment #7)
> (From update of attachment 82828 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82828&action=review
> 
> > Source/WebKit/chromium/public/WebMediaPlayer.h:132
> > +    virtual unsigned long decodedFrames() const = 0;
> 
> nit: webkit style is to just use "unsigned" instead of "unsigned long"

Will fix.

> 
> nit: are "decodedFrames" and "droppedFrames" meant to return counts of {decoded,dropped}Frames?
> if so, the names of these methods could be improved.  as is, it sounds like the methods should
> be returning sets of frames--one set of decoded frames and one set of dropped frames, but clearly
> that's not what they do since they return integers.
> 
> How about one of these names?
> 
>   {count,number}Of{Decoded,Dropped}Frames
>   {decoded,dropped}FrameCount

I like the second ({decoded,dropped}FrameCount). Note that this is mirrored in the idl (HTML{Video,Media}Element.idl.

WebCore/html idl style seems to be to use "unsigned long" rather than "unsigned" though, yes? And the implementation HTML*Element.{cpp,h} is to use "unsigned"?

As I introduced this a couple of weeks ago, I think I should change the actual core APIs to match this (nothing depends on this as no port supports this yet).

I.e. I will:

1) Change WebCore to reflect the API change.
2) Make the changes to chromium
3) Fix up this patch that wires 1 and 2 together.

Sound like a plan? Will cc you on the changes.

> 
> > Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:453
> > +unsigned long WebMediaPlayerClientImpl::decodedFrames() const
> 
> looks like the WebCore interfaces have the same naming problem.

Yup - will fix as detailed above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.