[Webkit-unassigned] [Bug 53705] Viewport parsing no longer accepts "1.0; " value as valid.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 00:45:54 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53705





--- Comment #19 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-02-18 00:45:53 PST ---
I understand that you want to do the warning inside 

> +static float numericPrefix(const String& keyString, const String& valueString, Document* document, bool* ok)

But then maybe we should rename it and move the arguments around.

valueString and the ok are related to the actual parsing, and keyString and document are related to the warning.

Hmm, maybe this is just nitpicking, it is fine how it is. It is very localized code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list