[Webkit-unassigned] [Bug 53705] Viewport parsing no longer accepts "1.0; " value as valid.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53705





--- Comment #20 from Joseph Pecoraro <joepeck at webkit.org>  2011-02-18 11:01:45 PST ---
(In reply to comment #19)
> > +static float numericPrefix(const String& keyString, const String& valueString, Document* document, bool* ok)
> 
> But then maybe we should rename it and move the arguments around.
> 
> valueString and the ok are related to the actual parsing, and keyString and document are related to the warning.
> 
> Hmm, maybe this is just nitpicking, it is fine how it is. It is very localized code.

Yah, that also crossed my mind. I ordered the arguments the same as all the
other static methods in the file thinking it was better to be consistent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.