[Webkit-unassigned] [Bug 54693] [EFL] Fix coding style errors in RenderThemeEfl.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54693


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com
                   |kit.org                     |
  Attachment #82874|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-02-17 16:19:21 PST ---
Created an attachment (id=82874)
 --> (https://bugs.webkit.org/attachment.cgi?id=82874&action=review)
Patch

I make a patch for this. If parameter type represents parameter's meaning well, I think we don't need to add parameter unnecessarily.
Other port add just parameter type to function definition. (See also RenderThemeGtk.h, RenderThemeQt.h)

However, there are still style errors regarding underscore.

Source/WebCore/platform/efl/RenderThemeEfl.h:37:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/efl/RenderThemeEfl.h:38:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]

I don't know how to fix this errors yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.