[Webkit-unassigned] [Bug 54693] New: [EFL] Fix coding style errors in RenderThemeEfl.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 15:42:45 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54693

           Summary: [EFL] Fix coding style errors in RenderThemeEfl.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gyuyoung.kim at samsung.com


When I run check-webkit-style script with RenderThemeEfl.h, there are many style erros like ewk_view.h. 

Source/WebCore/platform/efl/RenderThemeEfl.h:37:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/efl/RenderThemeEfl.h:38:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/efl/RenderThemeEfl.h:104:  The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:104:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:149:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:181:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:182:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:182:  The parameter name "states" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:183:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:183:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:183:  The parameter name "i" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:183:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:208:  The parameter name "desc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:209:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:209:  The parameter name "desc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:226:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:226:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:231:  The parameter name "ce" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:231:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:232:  The parameter name "ce" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:233:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:233:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:234:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:234:  The parameter name "ce" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:235:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:235:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/RenderThemeEfl.h:235:  The parameter name "ce" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 27 in 1 files

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list