[Webkit-unassigned] [Bug 54425] Extract a function to process ancestor and their sibling nodes from processContents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54425





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-15 15:53:38 PST ---
(In reply to comment #2)
> (From update of attachment 82400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review
> 
> Seems OK. Not sure it needs to be a member function. I don’t see uses of data or function members. If I am right it could be a static member function or event a non-member function. Non-member would be good because we wouldn’t have to touch the header file.

The reason this function had to be a member function was because ActionType is declared private.  I could make ActionType public as well but then it seems to unnecessarily pollute WebCore namespace.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.