[Webkit-unassigned] [Bug 54425] Extract a function to process ancestor and their sibling nodes from processContents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54425


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82400|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-02-15 09:15:07 PST ---
(From update of attachment 82400)
View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review

Seems OK. Not sure it needs to be a member function. I don’t see uses of data or function members. If I am right it could be a static member function or event a non-member function. Non-member would be good because we wouldn’t have to touch the header file.

> Source/WebCore/dom/Range.cpp:866
> +    return clonedContainer;

Should be clonedContainer.release().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.