[Webkit-unassigned] [Bug 54313] DocumentThreadableLoader doesn't support WebURLLoader usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54313





--- Comment #12 from Bill Budge <bbudge at gmail.com>  2011-02-15 12:25:03 PST ---
(From update of attachment 82479)
View in context: https://bugs.webkit.org/attachment.cgi?id=82479&action=review

>> Source/WebCore/loader/DocumentThreadableLoader.cpp:240
>> +void DocumentThreadableLoader::didReceiveCachedMetadata(SubresourceLoader* loader, const char* data, int lengthReceived)
> 
> Ditto (with my comment below).

See my response, below.

>> Source/WebCore/loader/DocumentThreadableLoader.h:80
>> +        virtual void didReceiveCachedMetadata(SubresourceLoader*, const char*, int lengthReceived);
> 
> Do you need this overload? (I though it was only here because SubresourceLoaderClient was private but that is no longer true.)

I added it so that we could include the assertion logic of the other methods, which verify that it's not called improperly. The method doesn't do anything, but can then be called by any derived classes. In case we ever want to put some logic into this method in DocumentThreadableLoader, we wouldn't have to go change all the derived classes. But I will defer to you on this; if you feel it's better to leave it unimplemented, I will remove it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.