[Webkit-unassigned] [Bug 54313] DocumentThreadableLoader doesn't support WebURLLoader usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54313


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82479|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from David Levin <levin at chromium.org>  2011-02-15 11:10:58 PST ---
(From update of attachment 82479)
View in context: https://bugs.webkit.org/attachment.cgi?id=82479&action=review

r- to remove unnecessary overload. (If it is needed, give some short explanation and I'll r+.)

> Source/WebCore/loader/DocumentThreadableLoader.cpp:240
> +void DocumentThreadableLoader::didReceiveCachedMetadata(SubresourceLoader* loader, const char* data, int lengthReceived)

Ditto (with my comment below).

> Source/WebCore/loader/DocumentThreadableLoader.h:80
> +        virtual void didReceiveCachedMetadata(SubresourceLoader*, const char*, int lengthReceived);

Do you need this overload? (I though it was only here because SubresourceLoaderClient was private but that is no longer true.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.