[Webkit-unassigned] [Bug 54199] [GTK] Implement NativeWebKeyboard and WebContext classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54199





--- Comment #4 from Alejandro G. Castro <alex at igalia.com>  2011-02-15 04:35:00 PST ---
(In reply to comment #2)
> (From update of attachment 81963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81963&action=review
> 
> > Source/WebKit2/Shared/NativeWebKeyboardEvent.h:38
> > +#include <gdk/gdk.h>
> 
> I recommend using a tyepdef here instead of including all of GDK. You may need to change the member below.

I've tried to use a smart pointer but it also requires the struct definition, I guess the only option would be to use a raw pointer and handle it directly but not sure if avoiding the include deserves adding that kind of code. What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.