[Webkit-unassigned] [Bug 54199] [GTK] Implement NativeWebKeyboard and WebContext classes for WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 08:43:23 PST 2011


--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-02-15 08:43:23 PST ---
(From update of attachment 81963)
View in context: https://bugs.webkit.org/attachment.cgi?id=81963&action=review

>>>> Source/WebKit2/Shared/NativeWebKeyboardEvent.h:38
>>>> +#include <gdk/gdk.h>
>>> I recommend using a tyepdef here instead of including all of GDK. You may need to change the member below.
>> OK, I'll review it.
> I've tried to use a smart pointer but it also requires the struct definition, I guess the only option would be to use a raw pointer and handle it directly but not sure if avoiding the include deserves adding that kind of code. What do you think?

You should just be able to do a typedef union _GdkEvent GdkEvent; and have it hold a GOwnPtr<GdkEvent>.  I believe we do that in other places.

> Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:36
> +    , m_nativeEvent(*event)

I think you'll need to do gdk_event_copy here to ensure proper reference counting for the members.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list