[Webkit-unassigned] [Bug 54365] GraphicsContext: Add clip(IntRect) overload for Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54365





--- Comment #3 from Andreas Kling <kling at webkit.org>  2011-02-13 18:36:39 PST ---
(In reply to comment #2)
> (From update of attachment 82278 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82278&action=review
> 
> > Source/WebCore/platform/graphics/GraphicsContext.h:326
> > +#if PLATFORM(QT)
> > +        void clip(const IntRect&);
> > +#endif
> 
> I think we should add this cross-platform. For the other platforms we can the graphics context code convert the rectangle to floating point. You could put the version for all other platforms into GraphicsContextQt.cpp inside an #if !PLATFORM(QT) block.

Fair enough. The reason I didn't do it was because most (all?) call sites automatically started using the new overload since they were using the implicit FloatRect(IntRect) constructor before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.