[Webkit-unassigned] [Bug 54365] GraphicsContext: Add clip(IntRect) overload for Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54365


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82278|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-02-13 18:17:33 PST ---
(From update of attachment 82278)
View in context: https://bugs.webkit.org/attachment.cgi?id=82278&action=review

> Source/WebCore/platform/graphics/GraphicsContext.h:326
> +#if PLATFORM(QT)
> +        void clip(const IntRect&);
> +#endif

I think we should add this cross-platform. For the other platforms we can the graphics context code convert the rectangle to floating point. You could put the version for all other platforms into GraphicsContextQt.cpp inside an #if !PLATFORM(QT) block.

We really don’t want to start putting PLATFORM(QT) if statements into call sites!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.