[Webkit-unassigned] [Bug 53911] Deploy EditingStyle in applyBlockStyle and applyInlineStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53911





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-10 16:41:36 PST ---
(From update of attachment 81464)
View in context: https://bugs.webkit.org/attachment.cgi?id=81464&action=review

Thanks for the review, Tony.

>> Source/WebCore/ChangeLog:21
>> +        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead.
> 
> Is this because of the changes to removeInlineStyle() at ApplyStyleCommand.cpp:917,921?

Not really.  The reason is that EditingStyle::style() can return a null-pointer, and these functions previously assumed that the style is always not null.

>> Source/WebCore/editing/ApplyStyleCommand.cpp:895
>> +        style->textDirection(textDirection);
> 
> Nit: Do you need to check the return value here?

Oops, I must have done:
ASSERT(style->textDirection(textDirection));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.