[Webkit-unassigned] [Bug 53911] Deploy EditingStyle in applyBlockStyle and applyInlineStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53911


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81464|review?                     |review+
               Flag|                            |




--- Comment #3 from Tony Chang <tony at chromium.org>  2011-02-10 09:59:01 PST ---
(From update of attachment 81464)
View in context: https://bugs.webkit.org/attachment.cgi?id=81464&action=review

> Source/WebCore/ChangeLog:21
> +        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead.

Is this because of the changes to removeInlineStyle() at ApplyStyleCommand.cpp:917,921?

> Source/WebCore/editing/ApplyStyleCommand.cpp:895
> +        style->textDirection(textDirection);

Nit: Do you need to check the return value here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.