[Webkit-unassigned] [Bug 54080] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54080





--- Comment #3 from Alejandro G. Castro <alex at igalia.com>  2011-02-10 03:35:33 PST ---
(In reply to comment #2)
> Some comments from a non reviewer.

Thanks very much for the review.

> View in context: https://bugs.webkit.org/attachment.cgi?id=81796&action=review
> 
> > Source/WebKit2/Shared/gtk/UpdateChunk.cpp:57
> > +        encoder->encode(false);
> 
> Can we send an empty m_rect instead of a separate variable to signify that SharedMemory creation failed?
>

I guess it is better to do this kind of changes with all the shared memory patch that you are doing? I did not check much the sharedmemory patch you sent, just fixes to make it work.

> > Source/WebKit2/Shared/gtk/UpdateChunk.cpp:104
> > +    int stride = cairo_format_stride_for_width(CAIRO_FORMAT_ARGB32, m_rect.width());
> 
> This assumes that the bit depth is always 32 bit, can we provide an option to use a lower resolution for systems with less memory?
>

Yep, it is something pendind, I was not sure if it makes sense to do it now or keep this patch more simple. I'll check it.

> > Source/WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:79
> > +    cairo_surface_t* pixmap(updateChunk->createImage());
> 
> The return pixmap's status has to be checked using cairo_surface_status(pixmap) before using.
> 

Yep, I'll add this.

> > Source/WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:86
> > +
> 
> The cairo_surface_t also has to be destroyed.
> 
> > Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:45
> > +    cairo_surface_t* image = updateChunk->createImage();
> 
> image has to be destroyed.

Both fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.