[Webkit-unassigned] [Bug 54080] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54080





--- Comment #2 from Amruth Raj <amruthraj at motorola.com>  2011-02-09 23:21:24 PST ---
Some comments from a non reviewer.
View in context: https://bugs.webkit.org/attachment.cgi?id=81796&action=review

> Source/WebKit2/Shared/gtk/UpdateChunk.cpp:57
> +        encoder->encode(false);

Can we send an empty m_rect instead of a separate variable to signify that SharedMemory creation failed?

> Source/WebKit2/Shared/gtk/UpdateChunk.cpp:104
> +    int stride = cairo_format_stride_for_width(CAIRO_FORMAT_ARGB32, m_rect.width());

This assumes that the bit depth is always 32 bit, can we provide an option to use a lower resolution for systems with less memory?

> Source/WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:79
> +    cairo_surface_t* pixmap(updateChunk->createImage());

The return pixmap's status has to be checked using cairo_surface_status(pixmap) before using.

> Source/WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:86
> +

The cairo_surface_t also has to be destroyed.

> Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:45
> +    cairo_surface_t* image = updateChunk->createImage();

image has to be destroyed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.