[Webkit-unassigned] [Bug 53749] Templatize KURLGooglePrivate::init

Wed Feb 9 22:57:17 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=53749

Brett Wilson (Google) <brettw at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |ctruta at chromium.org
                   |kit.org                     |
                 CC|                            |brettw at chromium.org
     Ever Confirmed|0                           |1

--- Comment #6 from Brett Wilson (Google) <brettw at chromium.org>  2011-02-09 22:57:17 PST ---
I'm not a super template instantiation expert. Normally you'd need to define the function in the header so all the callers for the different types see the same thing. That seems to not be necessary in this case because there are only two possible instantiations, and they're both instantiated from the .cpp file where the actual implementation is.

Maybe a real WebKit reviewer has an idea for if there is a better method more commonly used in WebKit for this kind of thing. But this looks good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.