[Webkit-unassigned] [Bug 53749] Templatize KURLGooglePrivate::init
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 4 11:47:11 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=53749
Cosmin Truta <ctruta at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81175|0 |1
is obsolete| |
Attachment #81175|review?, commit-queue? |
Flag| |
Attachment #81258| |review?, commit-queue?
Flag| |
--- Comment #5 from Cosmin Truta <ctruta at chromium.org> 2011-02-04 11:47:11 PST ---
Created an attachment (id=81258)
--> (https://bugs.webkit.org/attachment.cgi?id=81258&action=review)
Patch
(In reply to comment #4)
> This is by design and not a bogus failure.
Ok. I am resubmitting the patch, with the comments updated. check-webkit-style is now passing.
I replaced "NULL" with "0", "'\0'" or "null" as appropriate. I kept using the (dictionary word) "null" because it makes sense to refer to the "null string", and also because it has semantic meaning in the underlying classes (e.g. CString::isNull).
In fact, before this change, the spellings "null" and "NULL" were used interchangeably.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list