[Webkit-unassigned] [Bug 53071] [NRWT] Pull up a rebaseline feature into a single_test_runner out of each test_type.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53071


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81606|review?                     |review+
               Flag|                            |




--- Comment #6 from Tony Chang <tony at chromium.org>  2011-02-08 11:37:29 PST ---
(From update of attachment 81606)
View in context: https://bugs.webkit.org/attachment.cgi?id=81606&action=review

> Tools/ChangeLog:10
> +        This patch is a first step for eliminating test_type/* classes.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=53071

Is this covered by existing unit tests?  If not, it would be nice to add some (either in this patch or a follow up patch).

> Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:111
> +            self._save_baseline_data(driver_output.image_hash, ".checksum",
> +                                     encoding="ascii",
> +                                     generate_new_baseline=self._options.new_baseline)

In a separate patch, we could just get rid of the encoding flag.  If we encode the .checksum files as binary, it should be the same as ascii.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.