[Webkit-unassigned] [Bug 53071] [NRWT] Pull up a rebaseline feature into a single_test_runner out of each test_type.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 8 00:01:03 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=53071
--- Comment #5 from Hayato Ito <hayato at chromium.org> 2011-02-08 00:01:03 PST ---
Thank you for the review.
(In reply to comment #3)
> The changes look fine to me.
>
> Looking at _run_rebaseline(), it's not obvious to me that we should be writing new baselines if the test crashed or timed out. I realize this question predates your change, but maybe you could add a FIXME for someone to revisit this later?
Nice point. That wasted my time too some time ago.
I added a FIXME. Thank you.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list