[Webkit-unassigned] [Bug 53902] JSVariableObject::setRegisters should take PassOwnArrayPtr for registersArray.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53902





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-07 18:26:17 PST ---
(In reply to comment #2)
> (From update of attachment 81449 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81449&action=review
> 
> > Source/JavaScriptCore/runtime/JSVariableObject.h:162
> > +        ASSERT(registerArray.get() != d->registerArray.get());
> 
> I’m surprised that either get() is required. We should make the smart pointers work for equality comparison without using the get().

Oops, no.  That's just me being careless.  We don't need to call get manually.  Will fix before landing the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.