[Webkit-unassigned] [Bug 53902] JSVariableObject::setRegisters should take PassOwnArrayPtr for registersArray.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53902


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81449|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-02-07 08:17:32 PST ---
(From update of attachment 81449)
View in context: https://bugs.webkit.org/attachment.cgi?id=81449&action=review

> Source/JavaScriptCore/runtime/JSVariableObject.h:162
> +        ASSERT(registerArray.get() != d->registerArray.get());

I’m surprised that either get() is required. We should make the smart pointers work for equality comparison without using the get().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.