[Webkit-unassigned] [Bug 52136] Add TestOutput classes to webkitpy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52136





--- Comment #23 from James Kozianski <koz at chromium.org>  2011-02-06 16:26:38 PST ---
(In reply to comment #22)
> (From update of attachment 81184 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81184&action=review
> 
> Just a couple more nits I noticed. Sorry. :)

It's cool :-)

> 
> > Tools/Scripts/webkitpy/common/net/testoutput.py:95
> > +    def is_new_rebaseline_for(self, other):
> 
> is_new_baseline_for? a "rebaseline" is not really a thing. :)

Done.

> 
> > Tools/Scripts/webkitpy/common/net/testoutputset.py:79
> > +            if name_match and (actual_match or (self._include_expected and expected_match)):
> 
> nit: typical webkit style for this would be to invert the if clause and add a continue. makes for less deeply nested indents and arguably more readable code.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.