[Webkit-unassigned] [Bug 53756] Refactor and/or split and/or rename the extend-selection tests to be clearer what they're doing, and able to be run manually

Thu Feb 3 23:14:03 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=53756

--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-03 23:14:03 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Let's make more incremental changes.  We always prefer to have many small changes over having one big patch as long as each change is coherent.
> 
> Yes exactly, so long as each change is coherent.  If you look at the patch it's got a lot of renaming to make the vocabulary more consistent, code simplification, etc that spans the html as well as js files.  It would an unreasonable amount of effort to try to separate them.

We should do cleanup first.  You can even separate renaming into a separate patch.  That way, each patch's correctness will be self-evident.  Once we cleaned up the test, then we can split the tests or whatever you please to do.

In general, working on WebKit requires making changes locally and then splitting the changes into cleanup/refactoring and actual fix because it's patch author's responsibility to make sure the patch is small (~20KB) and changes are easy to review.

> > We could separate tests in line boundary into more categories if you wish.
> 
> After this change I hope to make the tests more clearly targeted, if possible.  I just want to make them manually testable for now, to help with another patch I'm working on :)

Yeah, separating tests into smaller tests will be nice because we'll be able to diagnose the issues more easily when they fail.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.