[Webkit-unassigned] [Bug 53756] Refactor and/or split and/or rename the extend-selection tests to be clearer what they're doing, and able to be run manually

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 23:00:19 PST 2011


--- Comment #9 from Benjamin (Ben) Kalman <kalman at chromium.org>  2011-02-03 23:00:19 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > I don't think I know what you mean?  What would the value in splitting up a change like this?  Changes to the script are necessary, and whether they're made all at once or incrementally the end result is the same, that is, there would be the same amount of doubt that they're still reporting correctly.
> > 
> > And I think the chances of them being different are quite low given
> >  - they're the same now
> >  - for any incorrect cases, the code is simpler now.
> Let's make more incremental changes.  We always prefer to have many small changes over having one big patch as long as each change is coherent.

Yes exactly, so long as each change is coherent.  If you look at the patch it's got a lot of renaming to make the vocabulary more consistent, code simplification, etc that spans the html as well as js files.  It would an unreasonable amount of effort to try to separate them.

> > > We need to find a better way of testing both LTR and RTL cases then.  I don't think it's acceptable to separate LTR/RTL tests; we'll have regressions in no time if we did that.
> > 
> > We could have both the LTR and RTL doms in the same test, but when I did that there were ~50 divs on the page and it becomes more difficult to spot what actually went wrong.  It's a tradeoff I guess.
> We could separate tests in line boundary into more categories if you wish.

After this change I hope to make the tests more clearly targeted, if possible.  I just want to make them manually testable for now, to help with another patch I'm working on :)

> > I still don't know how having them in separate tests implies regressions, though.
> Because extend-selection* doesn't print PASS/FAIL, there have been multiple occasions where people just rebaselined the expected result when the test started to fail on non-Mac platforms instead of actually fixing them.  And if we had LTR/RTL results on separate files, people are very unlikely to realize that those results supposed to match.

Ok I agree, thanks.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list