[Webkit-unassigned] [Bug 53255] Reversion should not be marked as misspelled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53255





--- Comment #9 from mitz at webkit.org  2011-02-03 11:11:29 PST ---
(From update of attachment 80902)
View in context: https://bugs.webkit.org/attachment.cgi?id=80902&action=review

Looks good. One comment/question though.

> Source/WebCore/editing/Editor.cpp:2745
> +    else
> +        // Pending correction should always be where caret is. But in case this is not always true, we still want to dismiss the panel without accepting the correction.
> +        dismissCorrectionPanel(ReasonForDismissingCorrectionPanelIgnored);
> +}

Since this is a 2-line else block, it should have braces around it. More importantly, though, by “should always be where [the] caret is”, do you mean it’s a programming mistake if it isn’t? In that case, there should be an assertion here (but we can keep the code that recovers from this situation gracefully for release builds).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.