[Webkit-unassigned] [Bug 53255] Reversion should not be marked as misspelled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53255





--- Comment #8 from jpu at apple.com  2011-02-02 00:21:08 PST ---
(In reply to comment #5)
> (From update of attachment 80458 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80458&action=review
> 
> > Source/WebCore/editing/Editor.cpp:2740
> > +    // Only apply correction if the caret is at the end of the range to be replaced.
> 
> Even this comment doesn’t add much. Perhaps you could explain the motivation instead.

The if statement probably should always evaluate to true. But since I'm not 100% sure that will be the case given the complexity of editing code, I added it to guard against upexpected case. I have rephrased the comment a bit.

Also, I just noticed that the name of this function really should be applyAutocorrectionBeforeTypingIfAppropriate() instead of applyAutocorrectionAfterTypingIfAppropriate(). I have changed it in latest patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.