[Webkit-unassigned] [Bug 53529] [fileapi] Add support for filesystem: URI handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53529





--- Comment #19 from Kinuko Yasuda <kinuko at chromium.org>  2011-02-02 17:32:48 PST ---
(From update of attachment 80975)
View in context: https://bugs.webkit.org/attachment.cgi?id=80975&action=review

>> Source/WebCore/fileapi/Entry.cpp:95
>> +    uriBuilder.append(m_fileSystem->asyncFileSystem()->type() == AsyncFileSystem::Temporary ? "temporary" : "persistent");
> 
> Do the strings "temporary" and "persistent" exist anywhere as constants?  It would be nice not to have them inline here.  At the very least they should be shared with the code that cracks the URI.

Same for the protocol name "filesystem"?

The changes in FileSystem callback chains to include type parameter lgtm.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.