[Webkit-unassigned] [Bug 53529] [fileapi] Add support for filesystem: URI handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 16:53:38 PST 2011


--- Comment #18 from Eric U. <ericu at chromium.org>  2011-02-02 16:53:38 PST ---
(From update of attachment 80975)
View in context: https://bugs.webkit.org/attachment.cgi?id=80975&action=review

> LayoutTests/fast/filesystem/filesystem-uri-origin.html:1
> +<a style="display:none" href="filesystem:http://www.webkit.org:8080/temporary/a/b/c/file.txt">foo</a>

Here you have webkit.org as the filesystem origin.  In directory-entry-to-uri-expected.txt you have file:// as the origin.  In an iframe test I see http://localhost:8000.  Please make sure these tests will work both on the webkit bots and when run locally.

> Source/WebCore/fileapi/Entry.cpp:95
> +    uriBuilder.append(m_fileSystem->asyncFileSystem()->type() == AsyncFileSystem::Temporary ? "temporary" : "persistent");

Do the strings "temporary" and "persistent" exist anywhere as constants?  It would be nice not to have them inline here.  At the very least they should be shared with the code that cracks the URI.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list