[Webkit-unassigned] [Bug 74661] Web Inspector: CodeGeneratorInspector.py: use generated types in method parameters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74661





--- Comment #5 from Peter Rybin <peter.rybin at gmail.com>  2011-12-17 09:40:03 PST ---
(In reply to comment #4)
> (From update of attachment 119516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119516&action=review
> 
> > Source/WebCore/inspector/CodeGeneratorInspector.py:665
> > +                        output.append("        };\n\n")
> 
> wrong indent.

Done

> 
> > Source/WebCore/inspector/CodeGeneratorInspector.py:1510
> > +                parameter_list.append("/*%s*/ %s %s" % (param_type_binding.get_in_c_type_text(json_optional), c_type.get_text(), parameter_name))
> 
> I'd like to see the suggested types in the comment section only if they differ from the current one.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.