[Webkit-unassigned] [Bug 74661] Web Inspector: CodeGeneratorInspector.py: use generated types in method parameters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 17 01:11:47 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=74661





--- Comment #4 from Ilya Tikhonovsky <loislo at chromium.org>  2011-12-17 01:11:47 PST ---
(From update of attachment 119516)
View in context: https://bugs.webkit.org/attachment.cgi?id=119516&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:665
> +                        output.append("        };\n\n")

wrong indent.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1510
> +                parameter_list.append("/*%s*/ %s %s" % (param_type_binding.get_in_c_type_text(json_optional), c_type.get_text(), parameter_name))

I'd like to see the suggested types in the comment section only if they differ from the current one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list