[Webkit-unassigned] [Bug 73926] [chromium] Race condition in CCLayerTreeHostTest shutdown

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 12:29:46 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73926





--- Comment #8 from Sami Kyostila <skyostil at google.com>  2011-12-14 12:29:46 PST ---
(In reply to comment #7)
> (From update of attachment 119199 [details])
> I'm biased, but I prefer the way I wrote this in https://bugs.webkit.org/attachment.cgi?id=119042&action=review (search for "runTaskIfNotShutdown") for a few minor reasons (we prefer early outs, it's better to take ownership of a PassOwnPtr<> ASAP, this is a bit non-obvious and deserves a comment). This does look correct, however. At the very least please add a comment the rest is up to you.

I agree, your patch looks better for the reasons you cited, so let's go with that one.

Should we merge this bug with the other one to keep tabs on when the fix goes in?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list