[Webkit-unassigned] [Bug 73926] [chromium] Race condition in CCLayerTreeHostTest shutdown
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 14 11:58:42 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=73926
James Robinson <jamesr at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #119199|review? |review+, commit-queue-
Flag| |
--- Comment #7 from James Robinson <jamesr at chromium.org> 2011-12-14 11:58:43 PST ---
(From update of attachment 119199)
I'm biased, but I prefer the way I wrote this in https://bugs.webkit.org/attachment.cgi?id=119042&action=review (search for "runTaskIfNotShutdown") for a few minor reasons (we prefer early outs, it's better to take ownership of a PassOwnPtr<> ASAP, this is a bit non-obvious and deserves a comment). This does look correct, however. At the very least please add a comment the rest is up to you.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list