[Webkit-unassigned] [Bug 73586] Upstream text codec and web string files of BlackBerry API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73586





--- Comment #11 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-12-13 18:03:18 PST ---
(From update of attachment 118926)
View in context: https://bugs.webkit.org/attachment.cgi?id=118926&action=review

Some minor comments.

> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:28
> +#include <wtf/Vector.h>
> +#include <wtf/text/CString.h>
> +#include <wtf/text/WTFString.h>

Wouldn't check-webkit-style complain about sorting problem? Sorting is case sensitive?

> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:32
> +using namespace WTF;

Is this needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.