[Webkit-unassigned] [Bug 73586] Upstream text codec and web string files of BlackBerry API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 18:37:31 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73586





--- Comment #12 from Jacky Jiang <zkjiang008 at gmail.com>  2011-12-13 18:37:31 PST ---
(From update of attachment 118926)
View in context: https://bugs.webkit.org/attachment.cgi?id=118926&action=review

>> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:28
>> +#include <wtf/text/WTFString.h>
> 
> Wouldn't check-webkit-style complain about sorting problem? Sorting is case sensitive?

If I remember correctly the ASCII of 'V' should be less than 't' and I don't see any complains.

>> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:32
>> +using namespace WTF;
> 
> Is this needed?

String, CString and Vector are using it, however, the header files may already declare it.  I can try to remove.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list