[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54623


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114018|review?                     |review-
               Flag|                            |




--- Comment #36 from Eric Seidel <eric at webkit.org>  2011-12-13 15:54:39 PST ---
(From update of attachment 114018)
This seems like a lot of copy-paste code.

I'm willing to believe that this *is* the right solution, but I need you to convince me of that.

Why is this the right abstraction layer?  Can we make this change at a lower level?  Could we add helper functions like "adjustRectForRTLAwareScrollBar" which would contain this ifdef and do nothing when this ifdef is disabled?

I'm nto sure what the right way to write this change is.  You are *much* more familiar with this code than I am, and I trust your judgement!

I do, however need you to convince me, and future readers of this patch, (in the ChangeLog, ideally) that this is the right way to go.

If you can come up with a solution which involves less copy-paste code, that would be ideal.

Thanks again for the patch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.