[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54623





--- Comment #35 from Eric Seidel <eric at webkit.org>  2011-12-13 15:49:07 PST ---
(From update of attachment 114018)
View in context: https://bugs.webkit.org/attachment.cgi?id=114018&action=review

This patch feels like it begs for some sort of abstraction.  It's unclear to me what that abstraction should look like, but a series of ifdefs seems wrong.  Can you clarify for me (and in the ChangeLog) which platforms would want this behavior vs. not?  Could we have a rtlAwareVerticalScrollbarWidth() which returns 0 when this is disabled, and thus we only would need the #ifdef in one place?

> Source/WebCore/rendering/RenderBlock.cpp:1475
> +#if USE(RTL_SCROLLBAR)

What platforms would want this disabled?   Normally we have defaults for these sorts of things in Platform.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.