[Webkit-unassigned] [Bug 74308] build-jsc passing incorrect args to buildGtkProject

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 10:27:37 PST 2011


--- Comment #4 from Andy Wingo <wingo at igalia.com>  2011-12-12 10:27:37 PST ---
> > +    my $allowWebKit2 = 1;
> > +    $result = buildGtkProject("JavaScriptCore", 0, 1, @ARGV);
> Do you mean to pass $allowWebKit2 here instead of 1?

Heh, indeed.  Will fix eventually.

(In reply to comment #3)
> I agree that this argument is a bit pointless for other projects.  I think it would be smarter to simply add --enable-webkit2=no to @options in build-webkit instead of keeping the extra argument around. What do you think?

The default in build-webkit is to enable it, so that should be the default in jsc, so as to avoid needless autofoo churn.  Therefore another way of defaulting it would be needed.  I punted.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list