[Webkit-unassigned] [Bug 74308] build-jsc passing incorrect args to buildGtkProject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74308





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-12-12 10:31:43 PST ---

> > I agree that this argument is a bit pointless for other projects.  I think it would be smarter to simply add --enable-webkit2=no to @options in build-webkit instead of keeping the extra argument around. What do you think?
> 
> The default in build-webkit is to enable it, so that should be the default in jsc, so as to avoid needless autofoo churn.  Therefore another way of defaulting it would be needed.  I punted.

Sorry, my proposal wasn't very clear:

1. Remove the WebKit2 argument completely.
2. If --no-webkit2 was passed to build-webkit, just add --enable-webkit2=no to @options in build-webkit.

This would allow us to have no code at all dealing with it in build-jsc and to avoid leaking details of this option down the call stack.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.