[Webkit-unassigned] [Bug 73911] <li value="0"> behaves like <li> (the same for negative numbers)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73911





--- Comment #13 from Darin Adler <darin at apple.com>  2011-12-07 11:00:39 PST ---
(In reply to comment #12)
> View in context: https://bugs.webkit.org/attachment.cgi?id=118228&action=review
> 
> > Source/WebCore/html/HTMLLIElement.cpp:-113
> > -        const AtomicString& requestedValueString = fastGetAttribute(valueAttr);
> > -        if (requestedValueString.isNull())
> > -            render->clearExplicitValue();
> 
> Are you saying that the isNull check is no longer needed, because valueOK will be false?

Yes. I suggested that change.

> How will this affect performance?

Should be minimal. The toInt function quickly returns failure with null string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.