[Webkit-unassigned] [Bug 73911] <li value="0"> behaves like <li> (the same for negative numbers)

Wed Dec 7 10:59:00 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=73911

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #12 from Alexey Proskuryakov <ap at webkit.org>  2011-12-07 10:59:00 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=118228&action=review

> Source/WebCore/html/HTMLLIElement.cpp:-113
> -        const AtomicString& requestedValueString = fastGetAttribute(valueAttr);
> -        if (requestedValueString.isNull())
> -            render->clearExplicitValue();

Are you saying that the isNull check is no longer needed, because valueOK will be false? Things like this should be explained in ChangeLog (this is why prepare-Script generates a list of modified functions).

How will this affect performance? At a first glance, it feels like a bigger issue than "inline" on setValue that you added.

> Source/WebCore/html/HTMLLIElement.cpp:111
> +    if (renderer() && renderer()->isListItem()) {

WebKit style prefers early return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.