[Webkit-unassigned] [Bug 73235] [Chromium] Support adding/removing page overlay to WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73235





--- Comment #35 from xiyuan <xiyuan at chromium.org>  2011-12-01 20:43:24 PST ---
(From update of attachment 117519)
View in context: https://bugs.webkit.org/attachment.cgi?id=117519&action=review

All done except removing dirtyRect, which I think needs a bit more discussion.

>> Source/WebKit/chromium/WebKit.gyp:263
>> +                'public/WebPageOverlayClient.h',
> 
> should be WebPageOverlay.h

Done.

Strange, gyp_webkit does not buff on this. :(

>> Source/WebKit/chromium/public/WebView.h:416
>> +    // graphical appearance of the WebView. WebPageOverlayClient paints the
> 
> WebPageOverlayClient -> WebPageOverlay

Done.

>> Source/WebKit/chromium/src/PageOverlay.cpp:150
>> +    FloatSize size(m_viewImpl->size().width, m_viewImpl->size().height);
> 
> m_viewImpl->size() is a WebSize, which (within WebKit code) can be implicitly converted to an IntSize, which in turn can be implicitly converted to a FloatSize
> 
> so this should just be "FloatSize size = m_viewImpl->size();" or "FloatSize size(m_viewImpl->size());" if you prefer that initialization style

Done.

>> Source/WebKit/chromium/src/PageOverlay.cpp:167

> 
> i think this can go back to what it previously did

Using dirtyRect could save unnecessary paints in composite code path.

>> Source/WebKit/chromium/src/PageOverlay.cpp:182
>> +    // WebPageOverlayClient does the actual painting of the overlay.
> 
> WebPageOverlayClient -> WebPageOverlay

Done.

>> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:275
>> +// WebPageOverlayClient
> 
> WebPageOverlayClient -> WebPageOverlay

Done.

>> Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:100
>> +    // WebPageOverlayClient
> 
> WebPageOverlayClient -> WebPageOverlay

Done.

>> Source/WebKit/chromium/src/WebViewImpl.h:96
>> +class WebPageOverlayClient;
> 
> WebPageOverlayClient -> WebPageOverlay, or remove this forward declaration if it isn't needed

Removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.