[Webkit-unassigned] [Bug 73235] [Chromium] Support adding/removing page overlay to WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73235





--- Comment #34 from xiyuan <xiyuan at chromium.org>  2011-12-01 19:47:40 PST ---
> > Source/WebKit/chromium/public/WebPageOverlay.h:43
> > +    // Returns dirty rect that needs repaint.
> > +    virtual WebRect dirtyRect() const = 0;
> 
> I think we should remove dirtyRect() completely from this patch and always consider the full viewport to be covered by every overlay.
> 

dirtyRect (or at least a needsRepaint flag) is needed for compositing mode so that we don't always repaint all overlays. This avoids unnecessary paintPageOverlay calls. For background dimming, it's static and does not change so we should only paint it once in composting mode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.