[Webkit-unassigned] [Bug 73603] nrwt shouldn't blow up when there are errors in test_expectations.txt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73603





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-12-01 17:35:59 PST ---
(In reply to comment #5)
> (In reply to comment #2)
> > We should just make it harder to check in failures.  webkit-patch land and webkit-patch land-cowboy should both check to see if test_expectations.txt has changed, if it has, run --lint-test-files.
> 
> I strongly support this; I view it as equivalent to a style check. It should no more be acceptable to check in expectation errors than any other kind of quickly-catchable error.

Sure, but adding things to webkit-patch doesn't help at all if people land patches with svn commit.

Anyhow, I don't think it's a big deal with a bad entry or two as long as bots are turned red because then gardeners can fix those errors in the next iteration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.