[Webkit-unassigned] [Bug 73603] nrwt shouldn't blow up when there are errors in test_expectations.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 17:29:51 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73603





--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2011-12-01 17:29:51 PST ---
(In reply to comment #2)
> We should just make it harder to check in failures.  webkit-patch land and webkit-patch land-cowboy should both check to see if test_expectations.txt has changed, if it has, run --lint-test-files.

I strongly support this; I view it as equivalent to a style check. It should no more be acceptable to check in expectation errors than any other kind of quickly-catchable error.

If --lint-test-files is too slow, we can look into speeding it up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list